feat: Extrait logique dans un helper

publicodes · May 15, 2024 · ab403c4 · ab403c4
1 parent a6f9212
commit ab403c4
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/source/migrations/migrateSituation.ts b/source/migrations/migrateSituation.ts
@@ -1,4 +1,5 @@
 import { DottedName, MigrationType, Situation } from '../../types/types'
+import { getValueWithoutQuotes } from './migrateSituation/getValueWithoutQuotes'
 import { handleSituationKeysMigration } from './migrateSituation/handleSituationKeysMigration'
 import { handleSituationValuesMigration } from './migrateSituation/handleSituationValuesMigration'
 import { handleSpecialCases } from './migrateSituation/handleSpecialCases'
@@ -47,12 +48,7 @@ export function migrateSituation({
       ]
 
     const formattedNodeValue =
-      typeof nodeValue === 'string' &&
-      nodeValue.startsWith("'") &&
-      nodeValue !== 'oui' &&
-      nodeValue !== 'non'
-        ? nodeValue.slice(1, -1)
-        : (nodeValue as string)
+      getValueWithoutQuotes(nodeValue) || (nodeValue as string)
 
     if (
       // We check if the value of the non supported ruleName value is a value to migrate.

diff --git a/source/migrations/migrateSituation/getValueWithoutQuotes.ts b/source/migrations/migrateSituation/getValueWithoutQuotes.ts
@@ -0,0 +1,11 @@
+export function getValueWithoutQuotes(value: string | number) {
+  if (
+    typeof value !== 'string' ||
+    !value.startsWith("'") ||
+    value === 'oui' ||
+    value === 'non'
+  ) {
+    return null
+  }
+  return value.slice(1, -1)
+}