Merge pull request #1440 from publishpress/release-v4.2.0

Release v4.2.0

.gitattributes

@@ -0,0 +1,39 @@
+*.code-workspace export-ignore
+.babelrc export-ignore
+.env.testing.linux.dist export-ignore
+.env.testing.mac.dist export-ignore
+.gitattributes export-ignore
+.github export-ignore
+.gitignore export-ignore
+.ide.php export-ignore
+.php-cs-fixer.cache export-ignore
+.phpcs.xml export-ignore
+.phplint-cache export-ignore
+.phplint.yml export-ignore
+.rsync-filters-pre-build export-ignore
+.rsync-filters-post-build export-ignore
+.vscode export-ignore
+Gruntfile.js export-ignore
+README.md export-ignore
+RoboFile.php export-ignore
+bin export-ignore
+builder export-ignore
+builder.yml export-ignore
+codeception.dist.yml export-ignore
+cs export-ignore
+/dev-workspace export-ignore
+/dist export-ignore
+jsconfig.json export-ignore
+legacy-tests export-ignore
+node_modules export-ignore
+package-lock.json export-ignore
+package.json export-ignore
+phpcs.xml export-ignore
+phpmd-ruleset.xml export-ignore
+psalm.xml export-ignore
+ray-dist.php export-ignore
+ray.php export-ignore
+screenshot-*.png export-ignore
+tests export-ignore
+webpack.config.js export-ignore
+/assets_wp export-ignore

.github/ISSUE_TEMPLATE/bug_report.md → .github/ISSUE_TEMPLATE/bug-report.md

@@ -2,19 +2,13 @@
 name: Bug report
 about: Create a report to help us improve
 title: ''
-labels: bug
+labels: 'unconfirmed bug'
 assignees: ''
 
 ---
 
-<!--- Your issue may already be reported! -->
-<!--- Please search on the [issue track](../) before creating one. -->
-
-If you have found a bug in the code of our plugins and want to report it, this is the best place! 
-
-However, please note that this option is for genuine bugs that can be reproduced on other sites. This is not for support questions about your site. We will close questions if they are about issues with your site.
-
-We have "PublishPress members" support available for commercial users and "Non-members" support for non-commercial users: https://publishpress.com/publishpress-support/
+<!--- Your issue may already be reported!
+Please search on the [issue track](../) before creating one. -->
 
 ## Expected Behavior
 

.github/ISSUE_TEMPLATE/release-free-plugin.md

@@ -1,39 +1,43 @@
 ---
-name: Release the Free version (team only)
-about: Describes default checklist for the plugin's release process.
+name: Release the Free Version (Team Only)
+about: Default checklist for the plugin's release process.
 title: Release PublishPress Authors v[VERSION]
 labels: release
 assignees: ''
-
 ---
 
-To release the Free plugin please make sure to check all the checkboxes below.
+To release the Free plugin, ensure you complete all the tasks below.
 
 ### Pre-release Checklist
-
-- [ ] Create the release branch as `release-<version>` based on the development branch
-- [ ] Make sure to directly merge or use Pull Requests to merge hotfixes or features branches into the release branch
-- [ ] Run `composer update` and check if there is any relevant update. Check if you need to lock the current version for any dependency. The `--no-dev` argument is optional here, since the build script will make sure to run the build with that argument.
-- [ ] Refresh language .pot file to update new string
-- [ ] Update the changelog - make sure all the changes are there with a user-friendly description and that the release date is correct
-- [ ] Update the version number to the next stable version. Use `$ vendor/bin/robo version <version-number>`
-- [ ] Commit the changes to the release branch
-- [ ] Build the zip package using `$ vendor/bin/robo build`. It should create a package in the `./dist` dir.
-- [ ] Send to the team for testing
+- [ ] Create a release branch named `release-<version>` from the development branch.
+- [ ] Review and merge all relevant Pull Requests into the release branch.
+- [ ] Start a dev-workspace session.
+- [ ] Execute `composer update` to update the root and lib vendors.
+- [ ] Review the updated packages. Mention any production library updates in the changelog.
+- [ ] Inspect GitHub's Dependabot warnings or Pull Requests for relevant issues. Resolve any false positives first, then fix and commit the remaining issues.
+- [ ] If necessary, build JS files for production using `composer build:js` and commit the changes.
+- [ ] Run a WP VIP scan with `composer check:phpcs` to ensure no warnings or errors greater than 5 exist.
+- [ ] Update the `.pot` file executing `composer gen:pot` and include a note in the changelog.
+- [ ] Especially for minor and patch releases, maintain backward compatibility for changes like renamed or moved classes, namespaces, functions, etc. Include deprecation comments and mention this in the changelog. Major releases may remove deprecated code, but always note this in the changelog.
+- [ ] Revise the changelog to include all changes with user-friendly descriptions and ensure the release date is accurate.
+- [ ] Update the version number in the main plugin file and `readme.txt`, adhering to specifications from our [tech documentation](https://rambleventures.slab.com/posts/version-numbers-58nmrk4b), and commit to the release branch.
+- [ ] Confirm there are no uncommitted changes.
+- [ ] Build the zip package with `composer build`, creating a new package in the `./dist` directory.
+- [ ] Distribute the new package to the team for testing.
 
 ### Release Checklist
+- [ ] Create and merge a Pull Request for the release branch into the `main` branch.
+- [ ] Merge the `main` branch into the `development` branch.
+- [ ] Establish the GitHub release on the `main` branch with the correct tag.
 
-- [ ] Create a Pull Request and merge the release branch it into the `master` branch
-- [ ] Merge the `master` branch into the `development` branch
-- [ ] Create the Github release (make sure it is based on the `master` branch and correct tag)
-
-#### SVN Repo\
-- [ ] Update your working copy using `$ svn update`
-- [ ] Cleanup the `trunk` directory.
-- [ ] Unzip the built package and move files to the `trunk`
-- [ ] Remove any eventual file that shouldn't be released in the package (if you find anything, make sure to create an issue to fix the build script)
-- [ ] Look for new files `$ svn status | grep \?` and add them using `$ svn add <each_file_path>`
-- [ ] Look for removed files `$ svn status | grep !` and remove them `$ svn rm <each_file_path>`
-- [ ] Create the new tag `$ svn cp trunk tags/<version>`
-- [ ] Commit the changes `$ svn ci -m 'Releasing <version>'`
-- [ ] Wait until WordPress updates the version number and make the final test updating the plugin in a staging site
+#### WP SVN Deployment
+- [ ] Navigate to the local copy of the SVN repo for the plugin.
+- [ ] Update your working copy using `svn update`.
+- [ ] Clear the `trunk` directory with `rm -rf trunk/*`.
+- [ ] Unzip the built package and transfer files to the `trunk` folder.
+- [ ] Remove any extraneous files (if found, create an issue to amend the `.rsync-filter-post-build` file). Keep only files really used on production.
+- [ ] Find new files with `svn status | grep \?` and add them using `svn add <each_file_path>`.
+- [ ] Identify removed files with `svn status | grep !` and delete them using `svn rm <each_file_path>`.
+- [ ] Create the new tag using `svn cp trunk tags/<version>`.
+- [ ] Commit the changes with `svn ci -m 'Releasing <version>'`.
+- [ ] Await WordPress's version number update and perform a final test by updating the plugin on a staging site.

.github/ISSUE_TEMPLATE/release-pro-plugin.md

@@ -1,31 +1,38 @@
 ---
-name: Release the Pro version (team only)
-about: Describes default checklist for releasing the Pro plugin;
+name: Release the Pro Version (Team Only)
+about: Default checklist for the plugin's release process.
 title: Release PublishPress Authors Pro v[VERSION]
 labels: release
 assignees: ''
-
 ---
 
-To release the Pro plugin please make sure to check all the checkboxes below.
+To release the Pro plugin, ensure you complete all the tasks below.
 
 ### Pre-release Checklist
-
-- [ ] Create the release branch as `release-<version>` based on the development branch
-- [ ] Make sure to directly merge or use Pull Requests to merge hotfixes or features branches into the release branch
-- [ ] Update the `composer.json` file changing the version constraint to the Free plugin to use the most recent stable release tag
-- [ ] Run `composer update` and check if there is any relevant update. Check if you need to lock the current version for any dependency. The `--no-dev` argument is optional here, since the build script will make sure to run the build with that argument.
-- [ ] Refresh language .pot file to update new string
-- [ ] Update the changelog - make sure all the changes are there with a user-friendly description and that the release date is correct
-- [ ] Update the version number to the next stable version. Use `$ vendor/bin/robo version <version-number>`
-- [ ] Commit the changes to the release branch
-- [ ] Build the zip package using `$ vendor/bin/robo build`. It should create a package in the `./dist` dir.
-- [ ] Send to the team for testing
+- [ ] Create a release branch named `release-<version>` from the development branch.
+- [ ] Review and merge all relevant Pull Requests into the release branch.
+- [ ] Start a dev-workspace session.
+- [ ] Verify the correct version of the free plugin is referenced in the `lib/composer.json` file. Prefer stable versions.
+- [ ] Execute `composer update` to update the root and lib vendors.
+- [ ] Review the updated packages and mention any production library updates in the changelog.
+- [ ] Check if all dependencies are synced from Free into the Pro plugin with `composer check:deps`. If required, merge dependencies using `composer fix:deps` and run `composer update` again.
+- [ ] Check if the free plugin uses Composer's autoload and copy the autoload definition from the free plugin to the pro plugin refactoring the relative paths, on `/lib/composer.json`. Execute `composer dumpautoload` to update the autoload files. Commit the changes.
+- [ ] Inspect GitHub's Dependabot warnings or Pull Requests for relevant issues. Resolve any false positives first, then fix and commit the remaining issues.
+- [ ] If necessary, build JS files for production using `composer build:js` and commit the changes.
+- [ ] Run a WP VIP scan with `composer check:phpcs` to ensure no warnings or errors greater than 5 exist.
+- [ ] Update the `.pot` file executing `composer gen:pot` and include a note in the changelog.
+- [ ] Especially for minor and patch releases, maintain backward compatibility for changes like renamed or moved classes, namespaces, functions, etc. Include deprecation comments and mention this in the changelog. Major releases may remove deprecated code, but always note this in the changelog.
+- [ ] Revise the changelog to include all changes with user-friendly descriptions and ensure the release date is accurate.
+  -- [ ] Update the version number in the main plugin file and `readme.txt`, adhering to specifications from our [tech documentation](https://rambleventures.slab.com/posts/version-numbers-58nmrk4b), and commit to the release branch.
+- [ ] Confirm there are no uncommitted changes.
+- [ ] Build the zip package with `composer build`, creating a new package in the `./dist` directory.
+- [ ] Distribute the new package to the team for testing.
 
 ### Release Checklist
+- [ ] Create and merge a Pull Request for the release branch into the `main` branch.
+- [ ] Merge the `main` branch into the `development` branch.
+- [ ] Establish the GitHub release on the `main` branch with the correct tag.
 
-- [ ] Create a Pull Request and merge the release branch it into the `master` branch
-- [ ] Merge the `master` branch into the `development` branch
-- [ ] Create the Github release (make sure it is based on the `master` branch and correct tag)
-- [ ] Update EDD registry and upload the new package
-- [ ] Make the final test updating the plugin in a staging site
+#### PublishPress.com Deployment
+- [ ] Update the EDD registry on the Downloads menu, uploading the new package.
+- [ ] Perform a final test by updating the plugin on a staging site.

.gitignore

@@ -28,9 +28,9 @@ node_modules
 
 /.properties.ini
 
-/vendor
-.idea
 /dist
 .env.testing
 builder.yml
 *.code-workspace
+
+/lib/**/.git

.phplint-cache

@@ -0,0 +1 @@
+{"core\/Factory.php":"6e5069fbf54d50efd7087546577349b7","core\/CustomFieldsModel.php":"1e9222f5f5d4854523b508804cccd71c","core\/Container.php":"ca353ebfd5339a6a1d451aecfa549faf","core\/Traits\/Author_box.php":"658370f20626f3d148267cc1071ce4e2","core\/Classes\/Post_Editor.php":"da7e8ff7e680efd3187123b1a9f36cd6","core\/Classes\/Author_Editor.php":"2dbf24842bd0b5f482b46b8de9646892","core\/Classes\/Admin_Ajax.php":"9cedeba326e18fac1f5a20d070397cf5","core\/Classes\/Author_Utils.php":"2df4d83f51b7ca80d8ee6882861b9c3a","core\/Classes\/Legacy\/LegacyPlugin.php":"8dc0ca0eb1da6041cdd492763aee8046","core\/Classes\/Legacy\/Util.php":"63674369755733bbf432a408bce653e4","core\/Classes\/Legacy\/Module.php":"d32495ba8d86fd9ae7d71cdefb21ea7a","core\/Classes\/Objects\/Post.php":"660ba3d9b6953b000b4a08f3f7fdf61d","core\/Classes\/CLI.php":"d5a91a4456f378337869c2ef7d4b7559","core\/Classes\/Objects\/Author.php":"504d4918026b227217ebf98a92cf6719","core\/Classes\/Authors_Iterator.php":"62dfcb19d9ceecb2fabb015f72203775","core\/Classes\/Content_Model.php":"bcae1d8ccb1e1768e1bf164381803189","core\/Classes\/Integrations\/Theme.php":"6c4b2a51b96bdf17a340d238051d03ee","core\/Classes\/Term_Editor.php":"71478be77f9204d030fef008671fcde2","core\/Classes\/Installer.php":"6c49ee0977998d845f2c0b73cb590a69","core\/Services.php":"95eb7cc0432d2a8722cc0d086a9125b3","core\/Classes\/Utils.php":"f3def3be0e7700dfbe990920a567a573","core\/Classes\/Query.php":"a4aef57e7f34250e07f8ce7467c403d3","core\/Plugin.php":"4cceac80e836f2f2567070ad99a1bddc","core\/Capability.php":"fb8452d962fec7643f545d5da1dc6e12","core\/Authors_Widget.php":"4d0b7b98eabedfe2d481a9077f9f91b9","core\/WP_Cli.php":"92c5ea7721615dbe46b74f190572bbc8","core\/Widget.php":"271fb062de2a27f3f4e9a5049ccf7618","core\/View.php":"726137e5ad839c9e98458da7f50e0b52","functions\/notify.php":"2edee979f33dcd77d1f0a9e7f5bcb079","core\/ViewInterface.php":"99fe7f18ef1d5c0bdf41ae7aded870db","functions\/bylines-functions.php":"3431568959a2abbe4be6a3322f359535","functions\/amp\/meta-author.php":"d565645ddf367886813ca27039ddd1e5","functions\/amp.php":"07ba57a33c41a88000b5929c2b6ad9f6","functions\/coauthors-functions.php":"0d3a420efa7d6f543a182cb17e8799cb","functions\/legacy-functions.php":"2cbc3e46adc0039ade42eeb0eac272c8","functions\/template-tags.php":"280fc29f73c5549b36197c69e507ac36","templates\/taxonomy-author.php":"333b12f0e74153e6d1989fc108412c34","templates\/parts\/author-pages-grid.php":"eac6bad4b6fe07d973833583a4deb963","templates\/parts\/author-pages-list.php":"ae9802cb8459b64465c97031d17994ab","modules\/polylang-integration\/polylang-integration.php":"d5fa3542d650b5085b8eae2d02b02f3d","modules\/seoframework-integration\/seoframework-integration.php":"60169cefa2e0bbb56c9f1f6c57728b16","modules\/elementor-integration\/Modules\/Posts\/Skins\/PostsSkinFullContent.php":"41ff765f919db1c589e9d794f0d3c31a","modules\/settings\/settings.php":"1f31411e52151a81d0c188ab230dc9bf","modules\/settings\/views\/settings.html.php":"bf591b164fed31151e7645d1116fc4a0","modules\/settings\/views\/module.html.php":"fe83ffdcd1ce87a8ef3ff07fd405af54","modules\/elementor-integration\/Modules\/Posts\/Skins\/PostsSkinClassic.php":"e9938a9f68a718d80d1608feca9c90d6","modules\/elementor-integration\/Modules\/Posts\/Skins\/PostsSkinCards.php":"a105e36fdedf612560fdc410345b9d5d","modules\/elementor-integration\/Modules\/ThemeBuilder\/Skins\/ArchivePostsSkinFullContent.php":"d4f28f8458b27f1f4a9d210f0479f93c","modules\/elementor-integration\/elementor-integration.php":"257ee658ebd518f8b07861c8af16bd0b","modules\/elementor-integration\/Modules\/ThemeBuilder\/Skins\/ArchivePostsSkinClassic.php":"aa94c0fda551329fa39e5dabfb1fa294","modules\/elementor-integration\/Modules\/ThemeBuilder\/Skins\/ArchivePostsSkinCards.php":"6ec230f54ed2286da5e4c4605f524506","modules\/byline-migration\/byline-migration.php":"38a94e666c20f44b3da7a8c48bfbe53f","modules\/yoast-seo-integration\/src\/YoastAuthor.php":"cbe20702e15da59d1d16c6b118c5763c","modules\/genesis-integration\/genesis-integration.php":"1fd9335627f3d463aa54b365c7d18ddc","modules\/yoast-seo-integration\/yoast-seo-integration.php":"9032172f303fee4d5850e7bde8c60450","modules\/yoast-seo-integration\/src\/SchemaFacade.php":"9ac847a314b8cb7de1074f46b9193f85","modules\/multiple-authors\/multiple-authors.php":"71469b5b45958125e77f6a06d55b86f4","modules\/bylines-migration\/bylines-migration.php":"17650ff2b6b361578d873815d5ac1cd9","modules\/modules-settings\/modules-settings.php":"8a1b6a1753cb366bf858a48f3171acac","modules\/editflow-integration\/editflow-integration.php":"9da7f32220fb672053b53c86fd7a9f58","modules\/ultimatemember-integration\/ultimatemember-integration.php":"1e768ed32628b8c57fc56ad189aab146","modules\/rank-math-seo-integration\/rank-math-seo-integration.php":"907a9c3e4a578554f08105b33c067bb6","modules\/divi-integration\/divi-integration.php":"e7c43e1c7191328a750c1303fe82c182","modules\/author-boxes\/classes\/AuthorBoxesEditorFields.php":"0af68ec68717545949be70c3b63759f0","modules\/author-boxes\/classes\/AuthorBoxesStyles.php":"e7b4b553c23e062d22918f57147ca811","modules\/author-boxes\/classes\/AuthorBoxesAjax.php":"7f7b08dc28646dcf5d094a6082587a85","modules\/author-boxes\/classes\/AuthorBoxesDefault.php":"5246635e1ce667c22ee54c8c812e6872","modules\/author-boxes\/author-boxes.php":"ca25b305446dfbfd23f914f2c7779b9d","modules\/author-custom-fields\/author-custom-fields.php":"76c3547c59655db9cdfe482344d2d52e","modules\/wpengine-integration\/wpengine-integration.php":"2861055808ff65adf43c9d5e3c81b255","modules\/default-layouts\/default-layouts.php":"4dc5a3299e30042ff42fc39f778498c4","modules\/generatepress-integration\/generatepress-integration.php":"7ec46c1bbda59f8c5970e1c4f0e68543","modules\/debug\/debug.php":"dfde2942614ca0818954b2169f50525d","modules\/rest-api\/rest-api.php":"805b0cc88020b5872fa8766c8b1e2761","modules\/reviews\/reviews.php":"b604a148a8b9a2fa3e56f56327a110aa","views\/footer-base.html.php":"f4f6cff8ea9998392f3c802368fcc762","views\/authors-list-widget-form.html.php":"7588e5b991aa9f77ca01d3d80fa921e9","views\/authors_recent.html.php":"7c8dd326580ef73540931931ae02ee64","views\/settings-tab.html.php":"b1c56b79a7444ef14905d2b9a5bf8628","views\/widget-form.html.php":"e4918bdfe32b9ebbd7f3f97bbd95f37c","views\/authors_index.html.php":"5fd02f11bf4a06e88514037a63be9eab"}

.rsync-filters-post-build

@@ -1,6 +1,5 @@
 - composer.json
 - composer.lock
-- .gitattributes
 - /vendor/pimple/pimple/.gitignore
 - /vendor/pimple/pimple/.php_cs.dist
 - /vendor/psr/container/.gitignore
@@ -30,4 +29,4 @@
 - /vendor/cmb2/cmb2/package-lock.json
 - /vendor/psr/container/README.md
 - /vendor/publishpress/wordpress-version-notices/.env.testing.dist
-- /vendor/symfony/polyfill-ctype/README.md
+- /vendor/symfony/polyfill-ctype/README.md

.rsync-filters-pre-build

@@ -30,18 +30,16 @@
 - README-build.md
 - README.md
 - RoboFile.php
-- assets/jsx
+- /assets/jsx
 - assets_wp
 - bin
 - builder
 - builder.yml
 - builder.yml.dist
 - codeception.dist.yml
-- cs
-- cypress
+- /cypress
 - cypress.json
-- dev-workspace
-- dist
+- /dev-workspace
 - jest.config.ts
 - jsconfig.json
 - legacy-tests