Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Made strings translatable in PHP files #870

Open
wants to merge 5 commits into
base: development
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/grouping/legacy-includes.php
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ function orgseries_grouping_import_existing_series() {
}

function orgseries_groups_admin_menu() {
add_submenu_page( 'edit.php', 'Series Categories', 'Series Categories', 'manage_publishpress_series', 'edit-tags.php?taxonomy=series_group');
add_submenu_page( 'edit.php', __('Series Categories', 'organize-series'), __('Series Categories', 'organize-series'), 'manage_publishpress_series', 'edit-tags.php?taxonomy=series_group');
}

function orgseries_group_add_queryvars($qvs) {
Expand Down
4 changes: 2 additions & 2 deletions includes-core/PPSeriesCoreAdmin.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ function ($settings) {
function ($settings) {
$settings['publishpress-series'] = [
'parent' => 'orgseries_options_page',
'label' => 'Upgrade to Pro',
'label' => __('Upgrade to Pro', 'organize-series'),
'link' => 'https://publishpress.com/links/series-banner',
];

Expand Down Expand Up @@ -110,4 +110,4 @@ public function publishpress_series_advertising_sidebar_banner(){
<?php
}

}
}
6 changes: 3 additions & 3 deletions orgSeries-manage.php
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ function add_series_form_fields($taxonomy) {
<div style="float:left;" id="selected-icon"></div>
<div style="clear:left;"></div>
<label for="series_icon">
<input id="series_icon_loc_display" type="text" style="width: 70%;" name="series_icon_loc_display" value="" disabled="disabled" /><input style="float:right; width: 100px;" id="upload_image_button" type="button" value="Select Image" />
<input id="series_icon_loc_display" type="text" style="width: 70%;" name="series_icon_loc_display" value="" disabled="disabled" /><input style="float:right; width: 100px;" id="upload_image_button" type="button" value="<?php esc_attr_e('Select Image', 'organize-series'); ?>" />
<input id="series_icon_loc" type="hidden" name="series_icon_loc" />
<p><?php _e('Upload an image for the series.', 'organize-series') ?></p>
</label>
Expand Down Expand Up @@ -272,7 +272,7 @@ function edit_series_form_fields($series, $taxonomy) {
<th scope="row"><?php _e('Series Icon Upload:', 'organize-series') ?></th>
<td><label for="series_icon">
<input id="series_icon_loc_display" type="text" size="36" name="series_icon_loc_display" value="" disabled="disabled"/>
<input id="upload_image_button" type="button" value="Select Image" />
<input id="upload_image_button" type="button" value="<?php esc_attr_e('Select Image', 'organize-series'); ?>" />
<p><?php _e('Upload an image for the series.', 'organize-series'); ?></p>
<input id="series_icon_loc" type="hidden" name="series_icon_loc" />
</label>
Expand Down Expand Up @@ -377,4 +377,4 @@ function pp_series_get_terms_orderby($orderby, $args)

return $orderby;
}
?>
?>
2 changes: 1 addition & 1 deletion orgSeries-options.php
Original file line number Diff line number Diff line change
Expand Up @@ -550,7 +550,7 @@ function series_automation_core_fieldset() {
<tr valign="top"><th scope="row"><label for="series_toc_url"><?php esc_html_e('Series Table of Contents URL:', 'organize-series'); ?></label></th>
<td>
<span id="toc-home-url"><?php bloginfo('url') ?>/</span><input type="text" name="<?php echo esc_attr($org_name); ?>[series_toc_url]" id="series_toc_url" value="<?php echo isset($org_opt['series_toc_url']) ? esc_attr(htmlspecialchars($org_opt['series_toc_url'])) : ''; ?>" />
<button onclick="gotoTOCUrl(event)" class="button">view page</button>
<button onclick="gotoTOCUrl(event)" class="button"><?php esc_html_e('view page', 'organize-series'); ?></button>

<?php
global $wp_rewrite;
Expand Down
6 changes: 3 additions & 3 deletions orgSeries-utility.php
Original file line number Diff line number Diff line change
Expand Up @@ -305,9 +305,9 @@ function is_ppseries_admin_pages(){
function ppseries_admin_settings_tabs(){

$settings_tabs = [
'series_automation_settings' => 'Display',
'series_icon_settings' => 'Icons',
'series_templates_settings' => 'Templates',
'series_automation_settings' => __('Display', 'organize-series'),
'series_icon_settings' => __('Icons', 'organize-series'),
'series_templates_settings' => __('Templates', 'organize-series'),
];

return apply_filters('ppseries_admin_settings_tabs', $settings_tabs);
Expand Down