fix: missing get and set methods for userId are added

pubnub · Aug 21, 2023 · 836f36d · 836f36d
1 parent 9584344
commit 836f36d
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 1 deletion.
diff --git a/dist/web/pubnub.js b/dist/web/pubnub.js
@@ -7710,6 +7710,8 @@
             this.setCipherKey = modules.config.setCipherKey.bind(modules.config);
             this.getUUID = modules.config.getUUID.bind(modules.config);
             this.setUUID = modules.config.setUUID.bind(modules.config);
+            this.getUserId = modules.config.getUserId.bind(modules.config);
+            this.setUserId = modules.config.setUserId.bind(modules.config);
             this.getFilterExpression = modules.config.getFilterExpression.bind(modules.config);
             this.setFilterExpression = modules.config.setFilterExpression.bind(modules.config);
             this.setHeartbeatInterval = modules.config.setHeartbeatInterval.bind(modules.config);

diff --git a/dist/web/pubnub.min.js b/dist/web/pubnub.min.js
diff --git a/lib/core/pubnub-common.js b/lib/core/pubnub-common.js
@@ -480,6 +480,8 @@ var default_1 = /** @class */ (function () {
         this.setCipherKey = modules.config.setCipherKey.bind(modules.config);
         this.getUUID = modules.config.getUUID.bind(modules.config);
         this.setUUID = modules.config.setUUID.bind(modules.config);
+        this.getUserId = modules.config.getUserId.bind(modules.config);
+        this.setUserId = modules.config.setUserId.bind(modules.config);
         this.getFilterExpression = modules.config.getFilterExpression.bind(modules.config);
         this.setFilterExpression = modules.config.setFilterExpression.bind(modules.config);
         this.setHeartbeatInterval = modules.config.setHeartbeatInterval.bind(modules.config);

diff --git a/src/core/pubnub-common.js b/src/core/pubnub-common.js
@@ -254,6 +254,10 @@ export default class {
 
   getUUID;
 
+  setUserId;
+
+  getUserId;
+
   getFilterExpression;
 
   setFilterExpression;
@@ -669,6 +673,8 @@ export default class {
     this.setCipherKey = modules.config.setCipherKey.bind(modules.config);
     this.getUUID = modules.config.getUUID.bind(modules.config);
     this.setUUID = modules.config.setUUID.bind(modules.config);
+    this.getUserId = modules.config.getUserId.bind(modules.config);
+    this.setUserId = modules.config.setUserId.bind(modules.config);
     this.getFilterExpression = modules.config.getFilterExpression.bind(modules.config);
     this.setFilterExpression = modules.config.setFilterExpression.bind(modules.config);
 

diff --git a/test/integration/components/config.test.js b/test/integration/components/config.test.js
@@ -42,6 +42,17 @@ describe('components/config', () => {
       assert.equal(pubnub.getUUID(), 'uuid2');
     });
 
+    it('get/set userId', () => {
+      let pubnub = new PubNub({
+        subscribeKey: 'mySubKey',
+        publishKey: 'myPublishKey',
+        userId: 'userId1',
+      });
+      assert.equal(pubnub.getUserId(), 'userId1');
+      pubnub.setUserId('userId2');
+      assert.equal(pubnub.getUserId(), 'userId2');
+    });
+
     it('throws when both userId and uuid are provided', () => {
       let config = { subscribeKey: 'demo', publishKey: 'demo', uuid: 'myUuid', userId: 'myUserId' };