Skip to content

Commit

Permalink
build: bumped minimum NodeJS version for tests
Browse files Browse the repository at this point in the history
Bumped used NodeJS version to start from 18 because lower version EOL'ed.
  • Loading branch information
parfeon committed Apr 1, 2024
1 parent 12e87ed commit a0da6d8
Show file tree
Hide file tree
Showing 6 changed files with 31 additions and 85 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,10 @@ jobs:
strategy:
fail-fast: true
matrix:
node: [14, 16]
node: [18, 20]
env: ['ci:node']
include:
- node: 16
- node: 18
env: 'ci:web'
steps:
- name: Checkout repository
Expand Down
2 changes: 1 addition & 1 deletion dist/web/pubnub.js
Original file line number Diff line number Diff line change
Expand Up @@ -11969,7 +11969,7 @@
constructor(configuration) {
var _a;
const configurationCopy = setDefaults(configuration);
const platformConfiguration = Object.assign(Object.assign({}, configurationCopy), { sdkFamily: 'Nodejs', PubNubFile });
const platformConfiguration = Object.assign(Object.assign({}, configurationCopy), { sdkFamily: 'Web', PubNubFile });
// Prepare full client configuration.
const clientConfiguration = makeConfiguration(platformConfiguration, (cryptoConfiguration) => {
if (!cryptoConfiguration.cipherKey)
Expand Down
2 changes: 1 addition & 1 deletion dist/web/pubnub.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion lib/web/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class PubNub extends PubNubCore {
constructor(configuration) {
var _a;
const configurationCopy = setDefaults(configuration);
const platformConfiguration = Object.assign(Object.assign({}, configurationCopy), { sdkFamily: 'Nodejs', PubNubFile });
const platformConfiguration = Object.assign(Object.assign({}, configurationCopy), { sdkFamily: 'Web', PubNubFile });
// Prepare full client configuration.
const clientConfiguration = makeConfiguration(platformConfiguration, (cryptoConfiguration) => {
if (!cryptoConfiguration.cipherKey)
Expand Down
103 changes: 25 additions & 78 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@
"form-data": "^4.0.0",
"lil-uuid": "^0.1.1",
"node-fetch": "^3.3.2",
"proxy-agent": "^6.3.0",
"superagent": "^8.1.2"
"proxy-agent": "^6.3.0"
},
"devDependencies": {
"@cucumber/cucumber": "^7.3.1",
Expand Down

0 comments on commit a0da6d8

Please sign in to comment.