Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix revoke token method signature #375

Merged
merged 4 commits into from
May 22, 2024
Merged

Fix revoke token method signature #375

merged 4 commits into from
May 22, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented May 22, 2024

fix(pam): fix revoke token method signature

Fix revoke token method signature where mistakenly expected object with token field.

@parfeon
fix(pam): fix revoke token method signature
af181c9 
Fix revoke token method signature where mistakenly expected object with `token` field.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: fix This PR contains fixes to existing features. labels May 22, 2024
@parfeon parfeon self-assigned this May 22, 2024
mohitpubnub
mohitpubnub approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@mohitpubnub mohitpubnub left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

one observation:
I think there is typo in filename types/api/access-panager.ts (should be access-manager)

@parfeon
Copy link
Contributor Author

parfeon commented May 22, 2024

@pubnub-release-bot release

@parfeon parfeon merged commit fe9f173 into master May 22, 2024
7 checks passed
@parfeon parfeon deleted the fix/revoke-token-arguments branch May 22, 2024 19:03
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitpubnub mohitpubnub mohitpubnub approved these changes

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@techwritermat techwritermat Awaiting requested review from techwritermat techwritermat is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees

@parfeon parfeon

Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: fix This PR contains fixes to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@parfeon @pubnub-release-bot @mohitpubnub