Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with string signals #388

Merged
merged 4 commits into from
Jul 4, 2024
Merged

Fix issue with string signals #388

merged 4 commits into from
Jul 4, 2024

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Jul 3, 2024

fix(listener): fix issue with string signals

Fix issue because of which signals sent as string not handler properly.

Closes #387

@parfeon
fix(listener): fix issue with string signals
787b8d8 
Fix issue because of which signals sent as string not handler properly.
@parfeon parfeon added status: done This issue is considered resolved. priority: medium This PR should be reviewed after all high priority PRs. type: fix This PR contains fixes to existing features. labels Jul 3, 2024
@parfeon parfeon self-assigned this Jul 3, 2024
mohitpubnub
mohitpubnub approved these changes Jul 4, 2024
View reviewed changes
Copy link
Contributor

@mohitpubnub mohitpubnub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parfeon
Copy link
Contributor Author

parfeon commented Jul 4, 2024

@pubnub-release-bot release

@parfeon parfeon merged commit e8b2256 into master Jul 4, 2024
7 checks passed
@parfeon parfeon deleted the CLEN-2148 branch July 4, 2024 08:20
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohitpubnub mohitpubnub mohitpubnub approved these changes

@seba-aln seba-aln Awaiting requested review from seba-aln seba-aln is a code owner

@techwritermat techwritermat Awaiting requested review from techwritermat techwritermat is a code owner

@kazydek kazydek Awaiting requested review from kazydek kazydek is a code owner

Assignees

@parfeon parfeon

Labels
priority: medium This PR should be reviewed after all high priority PRs. status: done This issue is considered resolved. type: fix This PR contains fixes to existing features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Signal event required text params and docs updates
3 participants
@parfeon @pubnub-release-bot @mohitpubnub