-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use non-ABI jars for kotlin compilation. #41
Conversation
Adds two new kotlin_compile attributes: 1. verbose: for printing debugging info 2. args: for passing arbitrary args to compilation Adds new test from @jmmk re: tornadofx
@jmmk can you take a look at this PR and try it on your end? git_repository(
name = "org_pubref_rules_kotlin",
remote = "https://github.com/pubref/rules_kotlin.git",
commit = "4f780394cb3d4f1bb18b72179c1b2865e533c9bf",
) |
@iirina Can you check this? For kotlin compilation we need to assemble a list of jars to pass to kotlinc. I think I should probably be using the set of transitive full jars, is |
@pcj Confirmed that using However, I tested Jackson Kotlin module and it still failed. See gist here: https://gist.github.com/jmmk/842fac837b7af8ebefde85e476f9002d |
Took a look at the gist and added a comment. |
Slightly less naive attempt at excluding kotlin stdlib jars.
OK, I can't remember exactly why I was removing kotlin-stdlib.jar and kotlin-reflect.jar from classpath... Some experiment perhaps that I failed to remove. |
@pcj the Jackson example works after the latest commit |
Drop support for bazel < 0.7.0 (now uses JavaInfo provider)
|
Can you open a GH issue on bazel and assign it to me please? |
I created the issue bazelbuild/bazel#4297 (but do not have permission to make assignments). Thanks! |
Also adds two new kotlin_compile attributes:
Adds new test from @jmmk re: tornadofx
Fixes #40