Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update switch_python script to new default python version 3.9 #157

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gerrod3
Copy link
Contributor

@gerrod3 gerrod3 commented Apr 9, 2024

With the oci_env now using the new centos9 images, the default python version is now 3.9.

Note We can now publish other python version oci-images, but we haven't done so yet.

Comment on lines +6 to 9
if [[ "$NEWV" == "3.9" ]]; then
echo "using default python 3.9"
exit 0
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How's that useful? Isn't that preventing to ever switch back?
Sure if we used containers like they were designed, we'd just throw it away and create a new one. But if we used containers like they were designed, and not as a drop in replacement for vm's, we wouldn't have this script in the first place.

@dosas
Copy link

dosas commented Apr 17, 2024

Note We can now publish other python version oci-images, but we haven't done so yet.

As long as there are no container images for other python versions (3.10, 3.11, 3.12, ...) this is the only possibility to use a different version right now.

@mdellweg
Copy link
Member

Note We can now publish other python version oci-images, but we haven't done so yet.

As long as there are no container images for other python versions (3.10, 3.11, 3.12, ...) this is the only possibility to use a different version right now.

I guess, that's why we keep the script around for now.

Copy link
Member

@mdellweg mdellweg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In any case, this is an improvement over the previous state.

@mdellweg
Copy link
Member

BTW: What happens if you used the oci-env with a python 3.8 container base image?

@gerrod3
Copy link
Contributor Author

gerrod3 commented Apr 19, 2024

BTW: What happens if you used the oci-env with a python 3.8 container base image?

Nothing, but you wouldn't be able to specify using python 3.9.

@mdellweg mdellweg merged commit 9f2038c into pulp:main Apr 22, 2024
6 checks passed
@mdellweg
Copy link
Member

BTW: What happens if you used the oci-env with a python 3.8 container base image?

Nothing, but you wouldn't be able to specify using python 3.9.

That's technically a regression. But it's a dev tool and they should be able to handle it.

@gerrod3 gerrod3 deleted the 3.9-python branch April 22, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants