update all references to editor or editor view #13310
Conversation
|
Your site preview for commit 77dfd50 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-77dfd509.s3-website.us-west-2.amazonaws.com. |
There was a problem hiding this comment.
Hi @interurban ,
I just realized the esc env run blog still has the obsolete thumbprint content there:
Then click the **Get thumbprint** button. The thumbprint value that you will be presented with is what you can use to verify the certificate of the provider i.e. Pulumi.
{{< notes type="info" >}}
The AWS console generates the thumbprint value on your behalf. However, if you are creating the OIDC provider programmatically, you will need to generate this value yourself and provide the thumbprint value as a part of your resource definition. You can learn more about what a thumbprint is and how to generate/verify it by referring to the [relevant AWS documentation](https://docs.aws.amazon.com/IAM/latest/UserGuide/id_roles_providers_create_oidc_verify-thumbprint.html).
{{< /notes >}}
Are you able to include the removal of this part with this PR?
Also I see "Table view" is capitalized but not "document view". Is this intentional?
|
Thanks for the catch and review, yes no prob I'll edit that part of your blog as well. |
|
@interurban - We need to be mindful of where we call out "Table View" vs. "Table Editor". We can't call it Table view everywhere When we are directing users and when we talk about the 'feature' itself, we should call it Table Editor. When the concept of Editor is already introduced and we are talking about "how you edit" them, then we should mention it as "Table View" and "Document View". Let me know if that differentiation makes sense. Also, can we update the meta images, gifs, snapshots as well? |
Co-authored-by: arunkumar611 <[email protected]>
Co-authored-by: arunkumar611 <[email protected]>
|
Your site preview for commit d32c87a is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-d32c87ae.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit 2cbda6c is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-2cbda6c4.s3-website.us-west-2.amazonaws.com. |
Co-authored-by: arunkumar611 <[email protected]>
Co-authored-by: arunkumar611 <[email protected]>
|
Your site preview for commit b2eb598 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-b2eb598c.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit c211811 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-c211811c.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit e8daf99 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13310-e8daf99c.s3-website.us-west-2.amazonaws.com. |
Fixes: #11899
"Editor view" is now called "Document view"
Table view is still the same but ensure we call it "Table view" everywhere and not "Key-value Editor" or "Key-value Table editor"
Both Table view and Document view are "Editors", so we need to update the language accordingly.