Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: How to Install Helm Charts on Kubernetes with Pulumi - Part 1 #13609

Merged
merged 3 commits into from
Dec 13, 2024
Merged

feat: How to Install Helm Charts on Kubernetes with Pulumi - Part 1 #13609

merged 3 commits into from
Dec 13, 2024

Conversation

dirien
Copy link
Contributor

@dirien dirien commented Dec 12, 2024

Proposed changes

Unreleased product version (optional)

Related issues (optional)

@dirien dirien requested a review from a team as a code owner December 12, 2024 15:09
@pulumi-bot
Copy link
Collaborator

Your site preview for commit e6e08db is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-e6e08db0.s3-website.us-west-2.amazonaws.com.

toriancrane
toriancrane requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few recommendations for updates.

content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
content/tutorials/kubernetes-helm-part-one/index.md Show resolved Hide resolved
@pulumi-bot
Copy link
Collaborator

Your site preview for commit fb24cac is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-fb24cac9.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit b15c6bc is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-b15c6bca.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit d3771a5 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-d3771a50.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit bbb56e6 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-bbb56e61.s3-website.us-west-2.amazonaws.com.

@dirien dirien changed the title feat: Write ESC with K8 using ESO doc/tutorial feat: How to Install Helm Charts on Kubernetes with Pulumi - Part 1 Dec 12, 2024
@dirien dirien force-pushed the kubernetes-helm-part-one branch from bbb56e6 to 00ba3dc Compare December 13, 2024 16:09
@pulumi-bot
Copy link
Collaborator

Your site preview for commit 00ba3dc is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-00ba3dca.s3-website.us-west-2.amazonaws.com.

@pulumi-bot
Copy link
Collaborator

Your site preview for commit a6081a4 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-13609-a6081a40.s3-website.us-west-2.amazonaws.com.

toriancrane
toriancrane approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@toriancrane toriancrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dirien dirien merged commit 079deeb into master Dec 13, 2024
8 checks passed
@dirien dirien deleted the kubernetes-helm-part-one branch December 13, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toriancrane toriancrane toriancrane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dirien @pulumi-bot @toriancrane