Pulumi Import Bucket V2 example fix #13663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meagancojocar
temporarily deployed
to
testing
GitHub Actions
Inactive
t0yv0
reviewed
Dec 18, 2024
| @@ -38,7 +38,7 @@ Both approaches allow you to adopt and begin managing existing cloud resources w | |||
|
|
|||
| Import uses the selected stack's configured [provider](/docs/concepts/resources/providers/) to look up the desired resource in the cloud provider, read its current configuration, and add the resource to the stack to bring it under management by Pulumi from that point forward. For this, it requires two pieces of information: | |||
|
|
|||
| * The _type_ of cloud resource to import --- either as a type _token_ (a string that uniquely identifies a Pulumi resource type) when using the CLI or as a resource declaration when importing in code. The type token of an Amazon S3 Bucket resource, for example, is `aws:s3/bucketv2:BucketV2`. | |||
| * The _type_ of cloud resource to import --- either as a type _token_ (a string that uniquely identifies a Pulumi resource type) when using the CLI or as a resource declaration when importing in code. The type token of an Amazon S3 Bucket resource, for example, is `aws:s3/bucketV2:BucketV2`. | |||
There was a problem hiding this comment.
|
Your site preview for commit 27dbfdf is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-13663-27dbfdf9.s3-website.us-west-2.amazonaws.com. |
t0yv0
approved these changes
Dec 18, 2024
|
@t0yv0 I can just merge this or do we also need to update: https://github.com/pulumi/pulumi-aws/blob/df65048bb98916e5381bfc196653dd7e17db4664/provider/cmd/pulumi-resource-aws/schema.json#L348909 |
|
You can just merge. The ref'd schema is the source of truth and it has the correct form just as your change does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #13655
Proposed changes
Unreleased product version (optional)
Related issues (optional)