Set retention days on Upload Artifacts #2618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
danielrbradley
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Very much in favor of removing the cleanup workflow.
Is there any rational behind the 30 days for master and PRs but 90 days for all other workflows? I think PRs make sense to be shorter, but should we keep all other for 90 days ... unless there's a cost associated?
|
@danielrbradley - I'm keeping the status quo as far as I'm aware: pulumi/pulumi-aws#2649 (comment) It may be/have been a cost/storage issue? Either way, we can always remove the shorter retention period. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the artifact cleanup cron in favor of setting retention days on the artifact upload itself.
Fixes #2558.
Similar to pulumi/pulumi-aws#2649