Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ruby 3.2 to CI #215

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add Ruby 3.2 to CI #215

wants to merge 2 commits into from

Conversation

bastelfreak
Copy link
Contributor

No description provided.

@bastelfreak bastelfreak self-assigned this Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -1.08 ⚠️

Comparison is base (18907af) 79.26% compared to head (4a88cea) 78.19%.

❗ Current head 4a88cea differs from pull request most recent head b1f81eb. Consider uploading reports for the commit b1f81eb to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #215      +/-   ##
==========================================
- Coverage   79.26%   78.19%   -1.08%     
==========================================
  Files          15       15              
  Lines        1548     1605      +57     
==========================================
+ Hits         1227     1255      +28     
- Misses        321      350      +29
Impacted Files Coverage Δ
lib/beaker-puppet/helpers/facter_helpers.rb 93.33% <ø> (ø)
lib/beaker-puppet/helpers/puppet_helpers.rb 86.49% <ø> (-0.97%) ⬇️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhoblitt
Copy link

I am fine with this is theory but obviously CI should be passing before it is merged.

@smortex
Copy link
Contributor

smortex commented Apr 19, 2023

👋 @bastelfreak This branch is in your fork of the repository. Is it okay to push attempts to fix CI to it? If so I guess we can't amend the branch to fix broken fixes, in this case how should we proceed? Otherwise, what should we do (open new PR based on this one)?

@bastelfreak
Copy link
Contributor Author

you have full permissions in my branch and can also do force pushes/modify history. Feel free to hack on it!

@smortex
Copy link
Contributor

smortex commented Apr 19, 2023

The rest of the failures are caused by:

bastelfreak and others added 2 commits May 5, 2023 15:35
@bastelfreak
Add Ruby 3.2 to CI
3aea77f
@smortex @bastelfreak
Switch form Fixnum to Integer
b1f81eb 
Fixnum was an implementation detail of older Ruby versions and have been
the same as Integer since Ruby 2.4.  Ruby 3.2 stopped to provide this
"alias" so use the proper class name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhoblitt jhoblitt jhoblitt approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@bastelfreak bastelfreak

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bastelfreak @jhoblitt @smortex