Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(CAT-643) Add forge gem upload functionality #1403

Merged
merged 1 commit into from
Oct 15, 2024
Merged

(CAT-643) Add forge gem upload functionality #1403

merged 1 commit into from
Oct 15, 2024

Conversation

danadoherty639
Copy link
Contributor

@danadoherty639 danadoherty639 commented Oct 8, 2024

Summary

This PR adds the Forge module implementing its upload functionality instead of us maintaining our own method

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable)
  • Thought process behind the implementation.

Related Issues (if any)

Mention any related issues or pull requests.

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified.

Copy link
Contributor

@jordanbreen28 jordanbreen28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments. My initial thought about the redundant check wasn't quite right so ignore :-)

lib/pdk/module/release.rb Outdated Show resolved Hide resolved
pdk.gemspec Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.49%. Comparing base (e8cd9ae) to head (8dce59e).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1403      +/-   ##
==========================================
- Coverage   88.49%   88.49%   -0.01%     
==========================================
  Files         127      127              
  Lines        5329     5320       -9     
==========================================
- Hits         4716     4708       -8     
+ Misses        613      612       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jordanbreen28 jordanbreen28 merged commit 302c910 into main Oct 15, 2024
10 of 11 checks passed
@jordanbreen28 jordanbreen28 deleted the cat_643 branch October 15, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants