Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Debian12 Compability #2439

Merged
merged 4 commits into from
Sep 21, 2023
Merged

feat: add Debian12 Compability #2439

merged 4 commits into from
Sep 21, 2023

Conversation

Robnarok
Copy link
Contributor

@Robnarok Robnarok commented Aug 3, 2023

Summary

The current version is not suitable for Debian 12, which was released a few weeks ago. Unfortunately the new Debian Requires PHP 8.2

Additional Context

Add any additional context about the problem here.

  • Root cause and the steps to reproduce. (If applicable): Try to install a Debian 12 Host with this Module
  • Thought process behind the implementation.: i searched for the references of Debian and added the Cases for Debian 12. Afterwards i tried running Puppet with the forked Module on a Debian 12 Server and worked.

Related Issues (if any)

Checklist

  • 🟢 Spec tests.: i ran the unit Tests and they finished without any failtures :)
  • 🟢 Acceptance tests.: i couldnt manage to get the acceptance Tests running on my System yet (not because of the Changes, but because of my System)
  • Manually verified. (For example puppet apply)

@Robnarok Robnarok requested review from bastelfreak, ekohl, smortex and a team as code owners August 3, 2023 13:45
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2023

CLA assistant check
All committers have signed the CLA.

@TheMeier
Copy link

Well the spec tests are not run for debian-12 though in part because of this: voxpupuli/facterdb#283

https://github.com/puppetlabs/puppetlabs-apache/actions/runs/5751569702/job/15591026007?pr=2439#step:6:1 < - no debian-12 here

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 15, 2023

Well the spec tests are not run for debian-12 though in part because of this: voxpupuli/facterdb#283

https://github.com/puppetlabs/puppetlabs-apache/actions/runs/5751569702/job/15591026007?pr=2439#step:6:1 < - no debian-12 here

@TheMeier that's because the puppet officially not supporting Debian 12, thats where its underlining tools haven't included into spec test coverage.
Even though this PR gets merge, the Puppet official doesn't recommend for Debian 12 but you still can go unofficially.

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 15, 2023

Updating label as experimental just let other know that Debian 12 is not yet official

@Ramesh7
Copy link
Contributor

Ramesh7 commented Sep 21, 2023

Taking this PR forward so that once we get hardware available for Debian12 we will get pipeline started running. Right now we do not have official support so do not recommend this to run with Debian 12 officially.

@Ramesh7 Ramesh7 merged commit 6588929 into puppetlabs:main Sep 21, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants