Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defaults memory_limit to undef instead of ignored 0b value #928

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AndrewLipscomb
Copy link
Contributor

Summary

From #748 - sets the default memory_limits value to undef instead of 0b. As the Docker documentation states that 0b is an impossible value to use - it appears to be ignoring the 0b value. In which case this should not be a breaking change to any setup.

Additional Context

Add any additional context about the problem here.

  • Also helps with podman usage as per the linked issue

Related Issues (if any)

#748

Checklist

  • 🟢 Spec tests.
  • 🟢 Acceptance tests.
  • Manually verified. (For example puppet apply)

@AndrewLipscomb AndrewLipscomb requested a review from a team as a code owner June 23, 2023 03:14
@AndrewLipscomb
Copy link
Contributor Author

As force pushes appeared to not update the old PR at #927 correctly - I've made a new PR. I've ran the unit tests via the PDK successfully on my local machine with this version

Copy link
Collaborator

@smortex smortex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template only output the parameter when it has a value, so this look safe. LGTM!

@Ramesh7
Copy link
Contributor

Ramesh7 commented Jul 6, 2023

Hi @ALTinners, can you please rebase your PR with main branch?
We have recently fixed the windows pipeline so yours should be green once you rebase. I will keep eye once its green will merge PR and release the changes.
Thanks

@smortex
Copy link
Collaborator

smortex commented Jul 6, 2023

From your working directory (in your feature branch, and assuming 'origin' is the name of the puppetlabs remote):

git fetch origin       # Download the latest code we have here
git rebase origin/main # Move your commits on top of the main branch (this re-write history)
git push -f            # Send the changes (-f is required because we re-wrote history)

The PR will be updated automagically.

@CLAassistant
Copy link

CLAassistant commented Aug 10, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ AndrewLipscomb
❌ tombrodie
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants