Avoid corrective changes when downloading packages via archive #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waipeng
reviewed
Jul 26, 2024
| @@ -422,7 +427,7 @@ | |||
| checksum => $runc_source_checksum, | |||
| checksum_verify => $runc_source_checksum_verify, | |||
| extract => false, | |||
| cleanup => false, | |||
| cleanup => $archive_cleanup, | |||
There was a problem hiding this comment.
since this archive resource has extract => false, maybe this isn't needed?
waipeng
reviewed
Jul 26, 2024
| @@ -469,7 +474,7 @@ | |||
| extract => true, | |||
| extract_command => 'tar xfz %s --strip-components=1 -C /usr/bin/', | |||
| extract_path => '/', | |||
| cleanup => true, | |||
| cleanup => $archive_cleanup, | |||
There was a problem hiding this comment.
$containerd_archive_cleanup ?
waipeng
reviewed
Jul 26, 2024
| @@ -494,7 +499,7 @@ | |||
| extract => true, | |||
| extract_command => 'tar xfz %s --strip-components=1 -C /usr/local/bin/', | |||
| extract_path => '/usr/local/bin', | |||
| cleanup => true, | |||
| cleanup => $archive_cleanup, | |||
There was a problem hiding this comment.
$etc_archive_checksum_cleanup ?
waipeng
reviewed
Jul 26, 2024
There was a problem hiding this comment.
@deric thanks for this! We are encountering the same issue.
I've made a few comments on the commit. In addition, I think we can do the following to determine the $_cleanup value
if $containerd_archive_checksum and $containerd_archive_checksum =~ /.+/ {
$containerd_archive_checksum_verify = true
$containerd_archive_creates = undef
$containerd_archive_cleanup = false
}
what do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Deleting downloaded archives might lead to corrective changes, like:
The
archive[cleanup]should have the same value for all archives.Checklist
puppet apply)