Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Managing unmanaged file resource #229

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kamlane
Copy link

@kamlane kamlane commented Feb 7, 2019

The Mount resource default statement is dependent on a resource not managed by the module so it bombs out; the exec statement at the bottom of logical_volume doesn't consistently execute on puppetserver 4.10 for some reason.

…anaged by the module; the exec statement at the bottom of logical_volume doesn't consistently execute on puppetserver 4.10
@Yamakasi
Copy link

Also please accept this commit, but it might be good to add something like this:

  if $mountpath == "/$name" {
        $mountpath_final = "/${name}"
  } else {
        $mountpath_final = "${mountpath}/${name}"
  }

... replace $mountpath with $mountpath_final in the lower code.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@d621bd9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #229   +/-   ##
=========================================
  Coverage          ?   72.96%           
=========================================
  Files             ?       17           
  Lines             ?      773           
  Branches          ?        0           
=========================================
  Hits              ?      564           
  Misses            ?      209           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d621bd9...530f792. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants