Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mariadb 11.x #1644

Closed
wants to merge 7 commits into from
Closed

Conversation

Marc-DRI
Copy link
Contributor

@Marc-DRI Marc-DRI commented Aug 28, 2024

Summary

Add support for Mariadb 11.x and use its mariadb and mariadbd binaries.

Additional Context

From Mariadb 11.0, mysql* names are deprecated in favor of mariadb* (cf. https://jira.mariadb.org/browse/MDEV-29582).
This pull request is:

  • including commits from @OxCom, determining which binaries to use, depending on the mysqld_version facter
  • fixing facters for mysql_version and mysqld_version whithin the MariaDB>11 context
  • updating/adding tests for this new context

The initial PR #1626 causes an infinite loop in our case of fresh deployment, because facter is not properly initialized.

Related Issues

This pull request manages to fix #1580 .

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2024

CLA assistant check
All committers have signed the CLA.

From MariaDB 11.x, mysql* names are deprecated
(cf. https://jira.mariadb.org/browse/MDEV-29582).

Use mariadb* names instead, to set factors accordingly.
Use these factors to return the proper client binary.

Co-authored-by: Sylvain Luce <[email protected]>
Co-authored-by: Nicolas Le Gaillart <[email protected]>
@Marc-DRI
Copy link
Contributor Author

Will reopen a MR without commits behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Providers broken with MariaDB 11
4 participants