Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: merge removeAnchors.sh and resetSolutions.sh #457

Merged
merged 3 commits into from
Sep 6, 2023

Conversation

softmoth
Copy link

Keeping it all in a single scripts/prepareExercises.sh avoids duplication.

Also remove the complex file finding; simply getting all source files within the exercises directory is a perfect fit for what is needed. This fixes Issue #430.

softmoth and others added 3 commits August 31, 2023 19:05
Keeping it all in a single `scripts/prepareExercises.sh` avoids
duplication.

Also remove the complex file finding; simply getting all source
files within the `exercises` directory is a perfect fit for what is
needed. This fixes Issue purescript-contrib#430.
@milesfrain
Copy link
Member

milesfrain commented Sep 6, 2023

Thanks for the PR.

I can't think of a situation where we need to selectively choose which operation to run, so let's just simplify things further and always do everything. I went ahead and pushed an update to your branch here, and also updated CI to run your new script.

The reason for the original complicated FIND_FILES_PATTERN regex is to not accidentally edit anything in the other directories found within each chapter's directory (e.g. dist, node_modules, output, etc.). But there's another simple way to just point to src and test, so I went ahead with making that edit too.

This runs on Linux for me.
Are there any Windows or Mac folks who can verify this still works for them too?

@softmoth
Copy link
Author

softmoth commented Sep 6, 2023

That looks great. I think there are some old finds that don't -print by default, that's why I had the parentheses and the explicit -print, but probably it's not needed if it works on OS X and FreeBSD as you've done it. Maybe people on #396 and #443 could help testing, since those are related?

@milesfrain milesfrain merged commit 427f698 into purescript-contrib:master Sep 6, 2023
2 checks passed
@softmoth softmoth deleted the issue403 branch September 9, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants