[Chapter 6] Add a note on optional type class instance names #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milesfrain
approved these changes
Nov 20, 2023
text/chapter6.md
Outdated
| This code declares a type class instance called `showBoolean` – in PureScript, type class instances can be named to aid the readability of the generated JavaScript. We say that the `Boolean` type _belongs to the `Show` type class_. | ||
| This code declares a type class instance; we say that the `Boolean` type _belongs to the `Show` type class_. | ||
|
|
||
| > Optionally, we can give names to type class instances to aid the readability of the generated JavaScript. For example: |
There was a problem hiding this comment.
Not blocking, but would be informative to include a snippet of the generated JS containing showBoolean. Even better would be to include both versions with and without the custom name.
But if this is too much detail, that explanation could go in the main docs and be linked to from the book.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.