Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert units.csv to units.json #9

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

stephengtuggy
Copy link

@stephengtuggy stephengtuggy commented Jun 3, 2022

For compatibility with the latest 0.9.x builds of the Vega Strike Game Engine.

Closes #7

@stephengtuggy stephengtuggy marked this pull request as ready for review June 3, 2022 19:08
@ermo
Copy link

ermo commented Aug 18, 2022

@stephengtuggy

I'm currently in the process of testing pwcu with VS 0.8.x and once I'm satisfied that that works reasonably well, I intend to branch and tag it and then get back to the VS 0.9.x compatibility work, which includes the present PR.

- Chuck Starchaser (Privateer: Parallel Universe lead)
- John Cordell (Privateer: Gemini Gold lead)
- [DMJC](https://github.com/DMJC) (Wing Commander: Universe lead)
- (to be filled in as I learn more about the long history this project)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add @ermo in too as he's the current lead on this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should get updated for this repo

Copy link
Member

@BenjamenMeyer BenjamenMeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing to update, and one note...overall looking good

trace(TRACE_WARNING, "::: What's in VS object %s :::" %(dir(VS)))
trace(TRACE_WARNING, "::: Engine Version {0} :::".format(engineVersion))
trace(TRACE_WARNING, "::: Asset API Version {0} :::".format(apiVersion))
# end VS Engine API version check
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stephengtuggy we (Vegastrike team) should post this code on its own and recommend people copy it in from that source so that we don't have to remember it for each game asset set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the note

@stephengtuggy stephengtuggy marked this pull request as draft December 9, 2023 02:00
@BenjamenMeyer
Copy link
Member

@stephengtuggy it's still missing the ships.json file

@stephengtuggy
Copy link
Author

@stephengtuggy it's still missing the ships.json file

@BenjamenMeyer Yeah... Unfortunately, I'm not sure when I'll get back to PWCU work. Got a lot of other stuff on my plate at the moment.

If someone else wants to pick this up and run with it, that would be great.

@BenjamenMeyer
Copy link
Member

I might by writing a tool to help. But it's going to be a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert units.csv to units.json
3 participants