Add IP field to the Add a Sensor page #732
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that when adding a sensor using the web-ui, the sensors IP was always set to whatever IP the PC I was using had at the moment.
This only made sense to me in the case of adding a sensor from the sensor itself, and I don't know how common that use case is.
So anyways, I added an optional IP field to that page so that one can set the sensors IP when adding it. If no IP is supplied, the old behaviour takes over.
I tested:
In all cases the result was as expected.