Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we just assume pandas dataframes as input? #9

Closed
amichuda opened this issue Oct 12, 2022 · 1 comment · Fixed by #14 · May be fixed by #7
Closed

Should we just assume pandas dataframes as input? #9

amichuda opened this issue Oct 12, 2022 · 1 comment · Fixed by #14 · May be fixed by #7
Milestone

Comments

@amichuda
Copy link
Collaborator

A lot of the data inputs you have in the boot_algo3 function in R assumes a dataframe. Should we just do the same and assume pandas dataframes in the python version? We can then turn them into numpy arrays in the function for performance.

This was linked to pull requests Oct 12, 2022
@amichuda amichuda added this to the v0.1 milestone Oct 12, 2022
@s3alfisc
Copy link
Member

s3alfisc commented Oct 12, 2022

Yes, this sounds like a good idea to me =) Though I do think that in most cases, there is no good reason in my code to assume a DataFrame (or only very R-centric reasons), so we could also be lenient and accept both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants