-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: Community package listing pages for astropy + SunPy #207
base: main
Are you sure you want to change the base?
Conversation
@@ -1,3 +1,90 @@ | |||
- package_name: astro-package3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are just dummy placeholder packages to test the search for astropy functionality - do not worry about the information in each of these but if we need new FIELDS that is something to consider
@lwasser , I vaguely remember you said you added a link back to "original review" to the listing of an accepted package in a mock-up. Was it this mockup? I don't see a preview link and I am not sure if the screenshots are up-to-date. Hope you can clarify. Thanks! |
hey @pllim i've actually been working on this!! it's not in this mockup branch YET (i need to rebase) BUT you can see it live on the website - i just pushed it. it took me a bit of time as i had to update the code that parses our reviews. but it's done now!! check it our here . now that it's working you can imaging the exact same thing on this mockup branch once i rebase! There is a tiny bug i need to fix on the packaging page in terms of sorting but that will be fixed in the next 30 minutes :) let me know if you have any other questions or if you need anything else. I have it on my list to review the APE in the upcoming days (most likely on monday). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a lot of comments when it comes to website designs. I should ping those listed under "Astropy.org web page maintainer" on https://www.astropy.org/team : @hamogu @dhomeier @eteq
At a glance though, you might need Astropy logo and banner that are also compatible with dark mode. We have some here that we use for astropy
documentation: https://github.com/astropy/astropy/tree/main/docs/_static
Thanks!
Landing page with community partner buttons
First - the landing page with new community specific buttons at the top leading to a community partner page
Search feature to find astropy affiliated packages on our main python-packages landing page.
Then we have the landing page where someone might search for astropy to find related packages.
Community landing page
I envision something like this (styles can be fixed) that listed only the affiliated packages. A few notes