Fix balance #1787
Draft
Fix balance #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. with the new prepare_data 2. when the balanced key has different set of values for train and development protocols.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
prepare_dataimplementation (which allows caching to file) changes how things are stored. The PR did not update[self.prepared_data["metadata"]->[self.prepared_data["metadata-values"]in the segmentation mixin.balance=['database','domain']), the implementation creates one sample generator for each possible combination (itertools.productof all values), but of course some combinations might not exist. To fix this, if the generator cannot produce anything, it returns a None as its first and only value (there might be a cleaner way).I don't have time to really test but it should fix nttcslab-sp/mamba-diarization#6 !
EDIT: might or might not work with pyannote's latest versions, needs testing