Update map generation to be more natural, turn off unnecessary settings #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove distance based richness Remove dead code Add trailing new line to generator-updates Final scrub of unused code Finalize map generation updates
John-Ender
commented
Aug 9, 2020
| @@ -292,7 +248,7 @@ else | |||
| --log(serpent.block(c.name)) | |||
| --log(serpent.block(c.position)) | |||
|
|
|||
| if c.name ~= "iron-rock" and c.name ~= 'seaweed' and c.name ~= 'fish' then | |||
| if RocksSet[c.name] == nil and c.name ~= 'seaweed' and c.name ~= 'fish' then | |||
There was a problem hiding this comment.
Not deleting generated resources is important because otherwise there are occasions when the next chunk is generated it will delete the resource generated on the nearby chunk leaving map artifacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the map generation logic to naturally spawn islands, and place generated resources on those islands.
Remove all resource spawning settings from map creation GUI since they don't do anything.
Added mod settings option to set distance based resource richness, defaulted to false to match King's design intention.
I also did a little bit of code organization and commenting to help others figure out what the intention of certain blocks is.