Fix handling of OpenAI system prompts #522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm it seems maybe this doesn't work for all models, we need to check. If not, we can revert to an earlier commit in the history. We should test it out and either use this approach if it works with the 1.59.0 SDK, or maybe use the contents of this commit (as you can see it in this PR): |
dmontagu
force-pushed
the
dmontagu/fix-handling-with-o1-system-role
branch
from
cf9444e to
6301c7a
Compare
Deploying pydantic-ai with
|
| Latest commit: |
6301c7a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21c34e60.pydantic-ai.pages.dev |
| Branch Preview URL: | https://dmontagu-fix-handling-with-o-f12g.pydantic-ai.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the most recent openai models want you to use role 'developer' rather than 'system'. This is documented here: https://platform.openai.com/docs/guides/text-generation#developer-messages.
This requires openai SDK version 1.59.0 which was published as a release on github about an hour ago but isn't on PyPI yet.
I updated the dependencies in this PR to use the github branch but we should change that to the real 1.59.0 release before merging, it just isn't available yet.