-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TensorFrame
#4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great :)
if x.dim() != 2: | ||
raise ValueError( | ||
f"x_dict['{stype_name}'] is not a 2-dimensional tensor.") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it be < 2
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. So far, we only support categorical/numerical/(ordinal) columns, so it should always be 2 dim. When we start supporting text/image columns, we can have a separate dimensionality check for those columns
We use
tensor_encoder
to transformDataFrame
intoTensorFrame
.