Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pytorch_tabular_benchmark.py #457

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Update pytorch_tabular_benchmark.py #457

merged 7 commits into from
Oct 2, 2024

Conversation

wsad1
Copy link
Member

@wsad1 wsad1 commented Sep 24, 2024

Add benchmark results to code comments.

wsad1 and others added 2 commits September 24, 2024 16:33
@wsad1 wsad1 requested a review from yiweny September 24, 2024 23:34
yiweny
yiweny reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@yiweny yiweny left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also add to the README? Just add a small section towards the end. You should also mention a few bullet points on the differences between Pytorch Tabular and Pytorch Frame.

@wsad1 wsad1 requested a review from yiweny September 30, 2024 21:16
@yiweny yiweny self-assigned this Oct 2, 2024
@yiweny yiweny merged commit 0d9647e into master Oct 2, 2024
12 of 13 checks passed
@yiweny yiweny deleted the wsad1-patch-1 branch October 2, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiweny yiweny yiweny approved these changes

Assignees

@yiweny yiweny

Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wsad1 @yiweny