Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base classes #7

Merged
merged 18 commits into from
Aug 16, 2023
Merged

Add base classes #7

merged 18 commits into from
Aug 16, 2023

Conversation

weihua916
Copy link
Contributor

Add base classes for TensorEncoder, FeatureEncoder, TableConv, Decoder.
Also add a simple test that instantiates each class and test e2e pipeline.

@weihua916 weihua916 requested a review from rusty1s August 16, 2023 01:12
@weihua916 weihua916 changed the base branch from master to tensor_frame August 16, 2023 01:13
@github-actions github-actions bot removed the data label Aug 16, 2023
zechengz
zechengz approved these changes Aug 16, 2023
View reviewed changes
Copy link
Member

@zechengz zechengz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM. Left some comments.

torch_frame/encoder/encoder.py Outdated Show resolved Hide resolved
torch_frame/nn/conv/table_conv.py Outdated Show resolved Hide resolved
torch_frame/nn/conv/table_conv.py Outdated Show resolved Hide resolved
torch_frame/nn/decoder/decoder.py Outdated Show resolved Hide resolved
torch_frame/nn/decoder/decoder.py Outdated Show resolved Hide resolved
torch_frame/nn/encoder/encoder.py Show resolved Hide resolved
test/nn/test_scaffold.py Outdated Show resolved Hide resolved
test/nn/test_scaffold.py Outdated Show resolved Hide resolved
rusty1s
rusty1s approved these changes Aug 16, 2023
View reviewed changes
torch_frame/encoder/__init__.py Show resolved Hide resolved
torch_frame/nn/conv/table_conv.py Show resolved Hide resolved
Base automatically changed from tensor_frame to master August 16, 2023 18:42
@weihua916 weihua916 merged commit 265451d into master Aug 16, 2023
6 of 7 checks passed
@weihua916 weihua916 deleted the scaffold branch August 16, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rusty1s rusty1s rusty1s approved these changes

@zechengz zechengz zechengz approved these changes

Assignees
No one assigned
Labels
nn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@weihua916 @rusty1s @zechengz