-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional McBackend support #6510
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6510 +/- ##
==========================================
- Coverage 91.91% 83.06% -8.86%
==========================================
Files 89 148 +59
Lines 14936 28018 +13082
==========================================
+ Hits 13729 23272 +9543
- Misses 1207 4746 +3539
|
c659bc6
to
68862bd
Compare
7178efb
to
0b425f5
Compare
4e31a43
to
8f81dfa
Compare
6ce32a0
to
75f7053
Compare
75f7053
to
345e3ce
Compare
Whoopsie, are you aware that the last commit changed the default for situations where McBackend is installed? |
I don't think we should change the default yet. |
This PR implements optional support for McBackend based trace backends.
This builds on top of the refactorings from #6475 that decoupled the
pm.sampling
module fromBaseTrace
.I split the addition of McBackend support into two commits, the first of which makes the necessary code changes without actually adding McBackend as a dependency for the test environments just to confirm that the optional importing works.
The
mcbackend.RunMeta
object that is created by themake_runmeta
function contains several important metadata about the current model variables. This includes information such as whether a variable is deterministic or not. Related issues:Checklist
New features
pm.sample(trace=...)
now acceptsmcbackend.Backend
instances.