feat(docs): contributing file update & envt fix #1779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes things if you are comfortable with this update to the envt:
i'll push the change now. we can always revert. NOTE: there are a bunch of other deprecation warnings that I have not tried to troubleshoot in that docs envt. i'm going to focus on the auth page update for now. |
lwasser
changed the title
ofek
approved these changes
Nov 7, 2024
|
Perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ofek this is a tiny pr to edit the contributing file. I am however having issues with the docs environment running correctly.I am going to work on another pr related to authentication after figuring things out last week.
The docs error that i am getting is:
it seems to not be a new error - mkdocs/mkdocs#3528
i'll focus on the content and if you need me to open a new issue about this i will. i've tried to delete the docs envt and create it again.