Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nushell #922

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Fix nushell #922

merged 4 commits into from
Aug 25, 2023

Conversation

flying-sheep
Copy link
Contributor

@flying-sheep flying-sheep commented Jul 28, 2023 •
edited
Loading

I took the liberty to broaden the types so the cast to list makes sense.

Fixes #921

ofek
ofek approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@flying-sheep
Copy link
Contributor Author

doesn’t seem like that test failure comes from my code

@flying-sheep
Copy link
Contributor Author

@ofek tests pass now

ofek
ofek requested changes Aug 25, 2023
View reviewed changes
src/hatch/utils/shells.py Show resolved Hide resolved
@flying-sheep flying-sheep requested a review from ofek August 25, 2023 15:38
ofek
ofek approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@ofek ofek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@ofek ofek merged commit 369d7c7 into pypa:master Aug 25, 2023
38 checks passed
github-actions bot pushed a commit that referenced this pull request Aug 25, 2023
@ofek
Fix nushell (#922)
e730cd4 
* Fix nushell

* conditional import 1

* conditional import 2 369d7c7
@flying-sheep flying-sheep deleted the fix-nushell branch August 25, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hatch shell broken for nushell
2 participants
@flying-sheep @ofek