-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a --group
option for installing from [dependency-groups]
found in pyproject.toml
in the current working directory
#13065
Open
sirosen
wants to merge
7
commits into
pypa:main
Choose a base branch
from
sirosen:dependency-groups
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+781
−1
Commits on Nov 1, 2024
-
Add 'dependency-groups==1.3.0' to vendored libs
Steps taken: - add `dependency-groups==1.3.0` to vendor.txt - add dependency-groups to vendor __init__.py - run vendoring sync - examine results to confirm apparent correctness (rewritten tomli imports)
Configuration menu - View commit details
-
Copy full SHA for 505b59a - Browse repository at this point
Copy the full SHA 505b59aView commit details -
Implement Dependency Group option:
--group
`--group` is supported on `download` and `install` commands. The option is parsed into the more verbose and explicit `dependency_groups` name on the parsed args. Both of these commands invoke the same processor for resolving dependency groups, which loads `pyproject.toml` and resolves the list of provided groups against the `[dependency-groups]` table. A small alteration is made to `pip wheel` to initialize `dependency_groups = []`, as this allows for some lower-level consistency in the handling of the commands.
Configuration menu - View commit details
-
Copy full SHA for 38aec3a - Browse repository at this point
Copy the full SHA 38aec3aView commit details
Commits on Nov 5, 2024
-
Add unit tests for dependency group loading
A new unit test module is added for parsing dependency groups and used to verify all of the pip-defined behaviors for handling dependency-groups. In one path, the underlying exception message from `dependency-groups` is exposed to users, where it should offer some explanation of why parsing failed, and this is therefore tested. Some related changes are applied to the dependency groups usage sites in the src tree. The signature of the dependency group requirement parse function is simplified, and its usage is therefore updated. A bugfix is applied to add a missing `f` on an intended f-string.
Configuration menu - View commit details
-
Copy full SHA for 164e731 - Browse repository at this point
Copy the full SHA 164e731View commit details -
Add initial functional tests for dependency-groups
This initial suite of tests is modeled fairly closely on existing tests for requirements files. Tests cover the following cases: - installing an empty dependency group (and nothing else) - installing from a simple / straightforward group - installing from multiple groups in a single command - normalizing names from the CLI and pyproject.toml to match - applying a constraints file to a dependency-group install
Configuration menu - View commit details
-
Copy full SHA for 1d80247 - Browse repository at this point
Copy the full SHA 1d80247View commit details -
Configuration menu - View commit details
-
Copy full SHA for 282f69e - Browse repository at this point
Copy the full SHA 282f69eView commit details
Commits on Nov 8, 2024
-
Per review, support on `pip wheel` is desirable. This is net-net simpler, since we don't need any trickery to "dodge" the fact that it is a `RequirementCommand` but wasn't supporting `--group`. The desire to *not* support `--group` here was based on a mistaken idea about what `pip wheel` does.
Configuration menu - View commit details
-
Copy full SHA for 6238f2c - Browse repository at this point
Copy the full SHA 6238f2cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dbdabb - Browse repository at this point
Copy the full SHA 9dbdabbView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.