Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow blanket and unused suppressions (PGH, RUF10) #4526

Merged
merged 1 commit into from
Oct 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ruff.toml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ extend-select = [
"FA", # flake8-future-annotations
"I", # isort
"PERF", # Perflint
"PGH", # pygrep-hooks (blanket-* rules)
"PYI", # flake8-pyi
"RUF10", # unused-noqa & redirected-noqa
"TRY", # tryceratops
"UP", # pyupgrade
"YTT", # flake8-2020
Expand Down
2 changes: 1 addition & 1 deletion setuptools/_distutils/compat/py38.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ def removeprefix(self, prefix):

def aix_platform(osname, version, release):
try:
import _aix_support # type: ignore
import _aix_support

return _aix_support.aix_platform()
except ImportError:
Expand Down
2 changes: 1 addition & 1 deletion setuptools/tests/config/test_apply_pyprojecttoml.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from ini2toml.api import LiteTranslator
from packaging.metadata import Metadata

import setuptools # noqa ensure monkey patch to metadata
import setuptools # noqa: F401 # ensure monkey patch to metadata
from setuptools.command.egg_info import write_requirements
from setuptools.config import expand, pyprojecttoml, setupcfg
from setuptools.config._apply_pyprojecttoml import _MissingDynamic, _some_attrgetter
Expand Down
Loading