Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies #1128

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix dependencies #1128

wants to merge 12 commits into from

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Oct 3, 2024

Fix for the environment specification.

Changes proposed in this Pull Request

Removed duplication between conda and pip dependencies and cleaned-up comments.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef ekatef mentioned this pull request Oct 3, 2024
8 tasks
@davide-f
Copy link
Member

Can this be merged? Any updates needed?

@ekatef
Copy link
Member Author

ekatef commented Oct 14, 2024

Can this be merged? Any updates needed?

No, all is still there I think 🙂
Thanks!

@ekatef
Copy link
Member Author

ekatef commented Nov 11, 2024

@davide-f do you have any objections if I'll merge it, once CI passes?

It's not a very impactful PR but it would be great to keep an environment specification clean

@davide-f
Copy link
Member

No no go ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants