Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix H2 and battery issues in prepare_sector_network #1145

Merged
merged 8 commits into from
Oct 31, 2024
Merged

Fix H2 and battery issues in prepare_sector_network #1145

merged 8 commits into from
Oct 31, 2024

Conversation

yerbol-akhmetov
Copy link
Collaborator

Changes proposed in this Pull Request

Good day. In this PR, changes are proposed to prepare_sector_network to fix the errors related to re-addition on H2 and battery carriers. Otherwise it was causing the following error. This PR is linked to issue #1144.

image

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@yerbol-akhmetov yerbol-akhmetov changed the title Fix prepare sector network Fix H2 and battery re-addition issue in prepare_sector_network Oct 16, 2024
@yerbol-akhmetov yerbol-akhmetov changed the title Fix H2 and battery re-addition issue in prepare_sector_network Fix H2 and battery fixes in prepare_sector_network Oct 18, 2024
@yerbol-akhmetov yerbol-akhmetov changed the title Fix H2 and battery fixes in prepare_sector_network Fix H2 and battery issues in prepare_sector_network Oct 18, 2024
@yerbol-akhmetov yerbol-akhmetov mentioned this pull request Oct 18, 2024
Closed
2 tasks
@yerbol-akhmetov yerbol-akhmetov marked this pull request as ready for review October 29, 2024 10:12
davide-f
davide-f reviewed Oct 29, 2024
View reviewed changes
Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As agreed also with hazem, this is ready to basically ready.
I'd recommend to add a line in minor changes and this is good to go for me :)

@davide-f davide-f linked an issue Oct 29, 2024 that may be closed by this pull request
H2 re-addition in sector causes error #1144
Closed
2 tasks
@yerbol-akhmetov
Copy link
Collaborator Author

As agreed also with hazem, this is ready to basically ready. I'd recommend to add a line in minor changes and this is good to go for me :)

Thank you @davide-f, I have added a release notes to minor changes.

@davide-f davide-f merged commit 4bf2e84 into pypsa-meets-earth:main Oct 31, 2024
4 checks passed
@yerbol-akhmetov yerbol-akhmetov deleted the fix_prepare_sector_network branch October 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davide-f davide-f davide-f approved these changes

@hazemakhalek hazemakhalek Awaiting requested review from hazemakhalek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

H2 re-addition in sector causes error
2 participants
@yerbol-akhmetov @davide-f