Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Environment fix #1146

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Environment fix #1146

merged 1 commit into from
Oct 16, 2024

Conversation

ekatef
Copy link
Member

@ekatef ekatef commented Oct 15, 2024

The PR addresses recently reported environment troubles (see discussion #1224).

Changes proposed in this Pull Request

A recent 1.4.1 release of rasterio seems to lead to some issues, while 1.3.11 works fine. The troubles may be windows-specific as the current runs of CI doesn't capture the problem while being rum on ubuntu and MacOS.

Checklist

  • I consent to the release of this PR's code under the AGPLv3 license and non-code contributions under CC0-1.0 and CC-BY-4.0.
  • I tested my contribution locally and it seems to work fine.
  • Code and workflow changes are sufficiently documented.
  • Newly introduced dependencies are added to envs/environment.yaml and doc/requirements.txt.
  • Changes in configuration options are added in all of config.default.yaml and config.tutorial.yaml.
  • Add a test config or line additions to test/ (note tests are changing the config.tutorial.yaml)
  • Changes in configuration options are also documented in doc/configtables/*.csv and line references are adjusted in doc/configuration.rst and doc/tutorial.rst.
  • A note for the release notes doc/release_notes.rst is amended in the format of previous release notes, including reference to the requested PR.

@ekatef
Copy link
Member Author

ekatef commented Oct 15, 2024

@davide-f could you please have a look? That is quite a urgent environment issue, and it would be great to merge it fast

Copy link
Member

@davide-f davide-f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't reproduce it but feel free to merge as appropriate if urgent

@ekatef
Copy link
Member Author

ekatef commented Oct 16, 2024

I can't reproduce it but feel free to merge as appropriate if urgent

I'm not able to reproduce it either, but we have multiple confirmations both of the problem itself, and the fact that this fix is working. My feeling is that it could make sense to add the fix, but I'd prefer to see CI happy before doing so 🙂

@ekatef
Copy link
Member Author

ekatef commented Oct 16, 2024

CI breaks for pre-commit (which seems to be the issue of pre-commit itself not quite connected with this PR), but runs for both the workflows. In the meantime, we have some more reports confirming that the fix is needed, so I think it's really a good idea to merge it now

@ekatef ekatef merged commit 0a6f98c into pypsa-meets-earth:main Oct 16, 2024
3 of 4 checks passed
@AlexanderMeisinger
Copy link
Contributor

AlexanderMeisinger commented Oct 17, 2024

I just double checked it again:

  • Using your fixed environment.yaml file
  • Creating new environment
  • Using fresh repository

Everything was working fine! The issue is solved.

davide-f pushed a commit to davide-f/pypsa-earth that referenced this pull request Oct 20, 2024
davide-f pushed a commit to davide-f/pypsa-earth that referenced this pull request Oct 20, 2024
GbotemiB pushed a commit to drifter089/pypsa-earth that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants