-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Environment fix #1146
Environment fix #1146
Conversation
@davide-f could you please have a look? That is quite a urgent environment issue, and it would be great to merge it fast |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't reproduce it but feel free to merge as appropriate if urgent
I'm not able to reproduce it either, but we have multiple confirmations both of the problem itself, and the fact that this fix is working. My feeling is that it could make sense to add the fix, but I'd prefer to see CI happy before doing so 🙂 |
CI breaks for pre-commit (which seems to be the issue of pre-commit itself not quite connected with this PR), but runs for both the workflows. In the meantime, we have some more reports confirming that the fix is needed, so I think it's really a good idea to merge it now |
I just double checked it again:
Everything was working fine! The issue is solved. |
The PR addresses recently reported environment troubles (see discussion #1224).
Changes proposed in this Pull Request
A recent
1.4.1
release ofrasterio
seems to lead to some issues, while1.3.11
works fine. The troubles may be windows-specific as the current runs of CI doesn't capture the problem while being rum on ubuntu and MacOS.Checklist
envs/environment.yaml
anddoc/requirements.txt
.config.default.yaml
andconfig.tutorial.yaml
.test/
(note tests are changing the config.tutorial.yaml)doc/configtables/*.csv
and line references are adjusted indoc/configuration.rst
anddoc/tutorial.rst
.doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.