-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop non string entries in country column of CO2_emissions data in prepare_transport_data_input
#1166
Drop non string entries in country column of CO2_emissions data in prepare_transport_data_input
#1166
Conversation
Hi, @hazemakhalek. Can you please review the bug fix provided in this PR? Currently CI fails due to that too. |
Hi Yerbol, this part I believe is legacy code that is not used anymore. Can you please confirm that in prepare_sector_network.py (this should be the only script we use this output file) and then we can omit the part of the emissions here altogether? |
Hi, @hazemakhalek. I have checked the |
Hi Yerbol, thanks for taking the time to check it. I meant only the CO2 emission part, not the whole file. Is it still being used in prepare_sector_network? |
Sorry @hazemakhalek for not mentioning, pypsa-earth/scripts/prepare_transport_data.py Lines 99 to 112 in 1075456
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a comment; what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great @yerbol-akhmetov and thanks for the clarification.
A minor stylistic comment, ready to merge right after
Co-authored-by: Davide Fioriti <[email protected]>
Many thanks :D merged :) |
Changes proposed in this Pull Request
Good day. Here I propose to update
download_co2_emissions
function inprepare_transport_data_input.py
script to drop entries where country column contains not string. This issue appeared very recently, as I have noticed it in the CI check. Great thanks for @finozzifa, who pointed out the error location and proposed the solution.Checklist
doc/release_notes.rst
is amended in the format of previous release notes, including reference to the requested PR.