add seaborn and matplotlib to install_requirements in setup.py
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjsrey
requested changes
Jul 2, 2018
| install_requires=['numpy', 'scipy', 'libpysal', 'mapclassify', 'palettable', | ||
| 'esda', 'pysal',], | ||
| install_requires=['numpy', 'libpysal', 'mapclassify', 'palettable', | ||
| 'esda', 'pysal', 'matplotlib', 'seaborn',], |
There was a problem hiding this comment.
seaborn requires matplotlib , so listing matplotlib here maybe redundant.
There was a problem hiding this comment.
Ideally I would like to cut ties to seaborn to keep dependencies as low as possible. So keeping them both might be an easy fix later on, when seaborn is removed? Otherwise I am happy to change that. What do you think?
There was a problem hiding this comment.
That makes sense. So this is good to go as is from my perspective.
sjsrey
approved these changes
Jul 2, 2018
This was referenced Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added
matplotlibandseabornto install requirementsto fix this issue: pysal/esda#19
and this one: pysal/giddy#47