feat(target_chains/starknet): pyth contract upgrade #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
Riateche
force-pushed
the
starknet-pyth-upgrade
branch
4 times, most recently
from
d551bc0
to
811d2e2
Compare
Riateche
changed the title
ali-bahjati
approved these changes
May 22, 2024
There was a problem hiding this comment.
Nice! Can you explain somewhere how the upgrade works? Based on your code I see that we need to have a vaa of the class-hash of the new contract. I can assume that there should be a method to upload the contract and it will be accessible by its hash (which is smart compared to other networks!)
Riateche
force-pushed
the
starknet-pyth-upgrade
branch
from
811d2e2
to
2e91050
Compare
ali-bahjati
approved these changes
May 22, 2024
|
I've added a comment. Yes, the new contract class must be declared in advance. Anyone who has the compiled contract artifact can declare it (but only once per network), and the class hash uniquely identifies all properties of the implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.