refactor(target_chains/starknet): use felt252 instead of bytes31 in ByteArray #1663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Riateche
force-pushed
the
starknet-no-bytes31
branch
from
ef27af1
to
be468dc
Compare
ali-bahjati
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I faced an issue when testing our contract with starknet-js. Looks like when we use
bytes31, in starknet-js we're only able to pass an ASCII string that's converted to cairo short string encoding. This is not what we want and it's not compatible with our use case (arbitrary binary data). Thus, I'm switching the storage type tofelt252, which has much more straightforward semantics in starknet-js (any number-like value is passed as the correspondingfelt252value).