Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved JavaScript extraction #332

Merged
merged 6 commits into from
Mar 9, 2016
Merged

Improved JavaScript extraction #332

merged 6 commits into from
Mar 9, 2016

Conversation

akx
Copy link
Member

@akx akx commented Jan 18, 2016

This PR improves the JavaScript message extraction system, adding support for

It's a refactor and superset of the previous JavaScript PRs, so:

Closes #298
Closes #310

@codecov-io
Copy link

Current coverage is 88.97%

Merging #332 into master will decrease coverage by -0.59% as of 2117212

@@            master    #332   diff @@
======================================
  Files           23      23       
  Stmts         3785    3800    +15
  Branches         0       0       
  Methods          0       0       
======================================
- Hit           3390    3381     -9
  Partial          0       0       
- Missed         395     419    +24

Review entire Coverage Diff as of 2117212

Powered by Codecov. Updated on successful CI builds.

@zackargyle
Copy link

This looks fantastic. Thanks for adding further support!

@catmeme
Copy link

catmeme commented Mar 8, 2016

Any progress on this? I am in need of dotted names as keywords. Thanks.

@akx
Copy link
Member Author

akx commented Mar 8, 2016

@catmeme If you feel like it, could you give the PR a quick code review pass?

@RauliL
Copy link

RauliL commented Mar 9, 2016

LGTM.

@akx
Copy link
Member Author

akx commented Mar 9, 2016

Merging. (@RauliL is a colleague who I recruited to do CR.)

akx added a commit that referenced this pull request Mar 9, 2016
Improved JavaScript extraction
@akx akx merged commit 124294a into python-babel:master Mar 9, 2016
@akx akx deleted the improved-js branch March 9, 2016 19:30
@zackargyle
Copy link

@akx, any chance you could update the pip package? We're ready to try out the new JSX extraction!

@lyapun
Copy link

lyapun commented Mar 31, 2016

@akx Yeah, we are waiting for this too :)

@sassanh
Copy link

sassanh commented Jul 15, 2016

@akx thanks for this great package. Unfortunately seems like the jsx support is not complete, it doesn't work on something like this:

<input ref='login-email' placeholder={gettext('username')}/>

is it the same for you or am I missing a config?

@sassanh
Copy link

sassanh commented Jul 15, 2016

@akx nevermind, I downloaded latest dev version (2.4.0-dev) and it's fixed.
It'd be great if you'd add make install in setup.py so that when someone installs a git commit using pip it generates locale-data.

@pyup-bot pyup-bot mentioned this pull request Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants