Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommentHandling: add support for #| and extend handling #~ comments #743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ProbstDJakob
Copy link

@ProbstDJakob ProbstDJakob commented Oct 15, 2020

  • renamed auto-comments to extracted-comments and user-comments to translator-comments see GNU PO-Files
  • add support for reading and writing "previous" comments (#| ) including previous msgctxt's
  • "obsolete" comments of various forms will now be accepted when reading (#~: , #~, , #~. , #~ , #~| )
  • write "obsolete" comments with all their details/comments (only "current" msgctxt, msgid, msgid_plural and msgstr were prefixed with #~ )
  • when processing (parsing) comments, remove defaulting to translator comments instead call _invalid_pofile with "Unknown comment type" as message

Closes #206
Closes #566

@codecov-io
Copy link

codecov-io commented Oct 15, 2020

Codecov Report

Merging #743 (e8fc9d5) into master (5afe2b2) will increase coverage by 90.94%.
The diff coverage is 93.49%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #743       +/-   ##
===========================================
+ Coverage        0   90.94%   +90.94%     
===========================================
  Files           0       24       +24     
  Lines           0     4218     +4218     
===========================================
+ Hits            0     3836     +3836     
- Misses          0      382      +382     
Impacted Files Coverage Δ
babel/messages/frontend.py 87.03% <ø> (ø)
babel/messages/pofile.py 94.25% <92.59%> (ø)
babel/messages/catalog.py 95.87% <100.00%> (ø)
babel/core.py 96.04% <0.00%> (ø)
babel/dates.py 91.60% <0.00%> (ø)
babel/numbers.py 97.70% <0.00%> (ø)
babel/support.py 83.20% <0.00%> (ø)
babel/lists.py 100.00% <0.00%> (ø)
babel/languages.py 100.00% <0.00%> (ø)
babel/localtime/__init__.py 65.00% <0.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5afe2b2...ab7dee1. Read the comment docs.

Jakob Probst added 2 commits December 17, 2020 14:10
- write obsolete entries entirely
- add support for reading "previous" (#| ) comments
- extend obsolete entry tests
- add test for reading "previous" (#| ) comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warns on commented out lines in po files Support previous-string comments (#|)
3 participants