Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move the distutils shim module back to a plain module #11

Closed
wants to merge 1 commit into from
Closed

move the distutils shim module back to a plain module #11

wants to merge 1 commit into from

Commits on Sep 26, 2023

  1. move the distutils shim module back to a plain module 

    * MANIFEST.in, the source layout, and pytest's default sys.path behavior conspired to mask a busted package, even though we were testing against the built package. `pytest` adds cwd to the path first, and since the `cffi` is in the root (grr), even though we're testing against the installed wheel, pytest loaded the subpackage from the source, masking that it was missing from the actual package (due to flat inclusions in MANIFEST.in). This is a longer-term problem that should be addressed by moving to a standard `src/` layout, and possibly also by bringing `_cffi_backend` in as a subpackage, but there are likely many dragons there with wheels that assume the presence of the top-level package.
    @nitzmahone
    nitzmahone committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9a2b60b View commit details
    Browse the repository at this point in the history