Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression introduced by #638 #676

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olivierHa
Copy link

Hello

Fixing #638 has introduced a regression with commit ad3862d
Indeed, user isn't defined.

Regards

@coveralls
Copy link

coveralls commented Aug 28, 2017

Coverage Status

Coverage remained the same at 24.667% when pulling c4ea8f8 on olivierHa:bugfix/user_not_defined into f2bece4 on python-diamond:master.

@JakSla
Copy link

JakSla commented Oct 20, 2017

this can also be used as an alternative
user = config['server']['user']

@shortdudey123
Copy link
Member

Can you rebase on master? As a side note, the alternative mentioned above won't work since user has two config sources, not one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants