Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly complete subcommands for fish #358

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

branchvincent
Copy link
Member

@branchvincent branchvincent commented Aug 21, 2023

Fixes #84
Fixes #359
Fixes #231
Fixes #366

@branchvincent branchvincent force-pushed the fish-completions branch 2 times, most recently from ddf41a8 to 8394f10 Compare August 21, 2023 09:16
@branchvincent branchvincent requested a review from Secrus August 21, 2023 09:16
@Secrus
Copy link
Member

Secrus commented Aug 21, 2023

Having an example here, would you be able/willing to add subcommands for ZSH as well? I think we can skip bash since making subcommands completions in bash is a real pain based on my research.

@branchvincent
Copy link
Member Author

Yea I'll look into zsh, might be a few days before I can get back to this

@Secrus Secrus mentioned this pull request Oct 25, 2023
@Secrus Secrus enabled auto-merge (squash) October 25, 2023 13:37
@Secrus Secrus merged commit f2b8075 into python-poetry:main Oct 25, 2023
16 checks passed
@branchvincent branchvincent deleted the fish-completions branch October 30, 2023 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants