-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Etsy OAuth2 Authentication bugs #880
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
=======================================
Coverage 77.77% 77.77%
=======================================
Files 347 347
Lines 10604 10606 +2
Branches 699 699
=======================================
+ Hits 8247 8249 +2
Misses 2200 2200
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
social_core/backends/oauth.py
Outdated
@@ -494,7 +494,7 @@ def get_code_verifier(self): | |||
|
|||
def generate_code_challenge(self, code_verifier, challenge_method): | |||
method = challenge_method.lower() | |||
if method == "s256": | |||
if method in ["s256", "S256"]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
„method“ should be lowercase here due to the previous line 496. Why would this change be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Removed this change.
Merged, thanks for your contribution! |
Proposed changes
Resolves Issue: #879
Types of changes
Please check the type of change your PR introduces:
Checklist
Other information
Note: This is a breaking change and could potentially break authentications.